Skip to content

async_q.join() sometimes never return#75

Merged
jettify merged 4 commits intoaio-libs:masterfrom
vlanse:master
Jan 28, 2018
Merged

async_q.join() sometimes never return#75
jettify merged 4 commits intoaio-libs:masterfrom
vlanse:master

Conversation

@vlanse
Copy link
Contributor

@vlanse vlanse commented Jan 26, 2018 •
edited
Loading

async_q.join() will never return in case when tasks are added to queue via sync_q.put()

@vlanse vlanse changed the title async_q.join() will never return in case when tasks are added to queu… async_q.join() sometimes never return Jan 26, 2018
@codecov
Copy link

codecov bot commented Jan 26, 2018 •
edited
Loading

Codecov Report

Merging #75 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   98.63%   98.63%   -0.01%     
==========================================
  Files           1        1              
  Lines         294      293       -1     
  Branches       41       41              
==========================================
- Hits          290      289       -1     
  Misses          2        2              
  Partials        2        2
Impacted Files Coverage Δ
janus/__init__.py 98.63% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d4155...78cde4a. Read the comment docs.

@jettify
Copy link
Member

jettify commented Jan 26, 2018

Change looks good, is there any way to construct test case that reproduces issue?

@vlanse
Copy link
Contributor Author

vlanse commented Jan 28, 2018

@jettify
added a test - it will hang forever without a patch, and it will pass with my changes
but had to use sleep() to enforce execution order on the loop

jettify
jettify reviewed Jan 28, 2018
View reviewed changes
tests/test_mixed.py Outdated

@asyncio.coroutine
def do_work():
yield from asyncio.sleep(1)
Copy link
Member

@jettify jettify Jan 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add loop=self.loop here? Looks like this is reason why on 3.4 test stuck.

Copy link
Contributor Author

@vlanse vlanse Jan 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, thanks for pointing this out 👍

@jettify
Copy link
Member

jettify commented Jan 28, 2018

Thanks a lot!

@jettify jettify merged commit 81c4622 into aio-libs:master Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jettify jettify jettify approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlanse @jettify