Merged
Conversation
Contributor
Author
|
Also, thank you for the library! I tried to address some of the CI and lint errors as well, but I'm happy to revert those if undesired. |
Member
|
@asvetlov I saw you released a new upload-coverage yesterday. Do you think you check what's failing here? |
Member
|
I'll take a look, thanks for the report. |
Contributor
Author
|
@Dreamsorcerer Would you mind kicking the build one more time? I think I traced down the issue to what seems to be missing sources, which seems to track since we don't |
Member
|
@blast-hardcheese you are correct. I'm working on the fix |
Member
|
All good now, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I believe it makes sense to export the underlying exception types to permit consumers to rely on consistent names and packages, so exporting the
Sync/AsyncEmpty/Fullexceptions to consumers.Are there changes in behavior for the user?
None, though those who are using LSPs such as pyright will notice warnings such as
will no longer be raised.
Related issue number
Checklist