Fix join calls not raise RuntimeError after queue closing.#295
Merged
asvetlov merged 3 commits intoaio-libs:masterfrom Oct 26, 2020
Merged
Fix join calls not raise RuntimeError after queue closing.#295asvetlov merged 3 commits intoaio-libs:masterfrom
asvetlov merged 3 commits intoaio-libs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
==========================================
+ Coverage 95.30% 95.52% +0.21%
==========================================
Files 4 4
Lines 1215 1274 +59
Branches 84 84
==========================================
+ Hits 1158 1217 +59
Misses 50 50
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
reviewed
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix
join()method calls not raiseRuntimeErrorafter queue closing.Are there changes in behavior for the user?
The
join()method calls will raiseRuntimeErrorafter queue closing.Related issue number
#294
Checklist