Skip to content

Fix import of PyBool_FromLong#653

Merged
bdraco merged 4 commits intoaio-libs:masterfrom
lysnikolaou:fix-cimport
Jun 2, 2025
Merged

Fix import of PyBool_FromLong#653
bdraco merged 4 commits intoaio-libs:masterfrom
lysnikolaou:fix-cimport

Conversation

@lysnikolaou
Copy link
Copy Markdown
Contributor

@lysnikolaou lysnikolaou commented Jun 2, 2025

What do these changes do?

  • Fix import of PyBool_FromLong. Use Cython's cimport instead.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modifications, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep the list in alphabetical order, the file is sorted by name.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.01%. Comparing base (d58b56f) to head (e0eefb0).
⚠️ Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   93.85%   94.01%   +0.15%     
==========================================
  Files          10       10              
  Lines         635      635              
  Branches       46       46              
==========================================
+ Hits          596      597       +1     
+ Misses         15       14       -1     
  Partials       24       24              
Flag Coverage Δ
CI-GHA 93.85% <ø> (+0.15%) ⬆️
MyPy 72.66% <ø> (ø)
OS-Linux 99.60% <ø> (+0.39%) ⬆️
OS-Windows 99.60% <ø> (+0.39%) ⬆️
OS-macOS 99.20% <ø> (ø)
Py-3.10.11 99.60% <ø> (+0.39%) ⬆️
Py-3.10.17 99.60% <ø> (+0.39%) ⬆️
Py-3.11.12 99.60% <ø> (+0.39%) ⬆️
Py-3.11.9 99.60% <ø> (+0.39%) ⬆️
Py-3.12.10 99.60% <ø> (+0.39%) ⬆️
Py-3.13.3 99.60% <ø> (+0.39%) ⬆️
Py-3.13.3t 99.60% <ø> (+0.39%) ⬆️
Py-3.9.13 99.60% <ø> (+0.39%) ⬆️
Py-3.9.22 99.60% <ø> (+0.39%) ⬆️
Py-pypy7.3.16 98.41% <ø> (ø)
Py-pypy7.3.19 98.41% <ø> (ø)
VM-macos-latest 99.20% <ø> (ø)
VM-ubuntu-latest 99.60% <ø> (+0.39%) ⬆️
VM-windows-latest 99.60% <ø> (+0.39%) ⬆️
pytest 99.60% <ø> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lysnikolaou

@bdraco bdraco merged commit 3b494bb into aio-libs:master Jun 2, 2025
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants