Exclude _frozenlist.cpp from bdists/wheels#649
Merged
bdraco merged 5 commits intoaio-libs:masterfrom Jun 2, 2025
Merged
Conversation
The Cython-generated C++ source file is quite large (about 500K, when everything else in the bdist is under 200K), and is not really useful at runtime.
bdraco
reviewed
May 5, 2025
bdraco
reviewed
May 5, 2025
Improve formatting and add attribution. Co-authored-by: J. Nick Koston <nick+github@koston.org>
5 tasks
Member
|
One last thing. |
bdraco
approved these changes
May 5, 2025
Member
|
Thanks. Will merge next time we are going to do a release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cython-generated C++ source file is quite large (about 500K uncompressed, when everything else in the bdist is under 200K on x86_64), and is not really useful at runtime. On x86_64, this change shrinks the compressed
.whlfile from 131K to 59K.What do these changes do?
Exclude
*.cppfiles from binary distributions such as wheels: specifically, this affects_frozenlist.cpp, which is generated by Cython from_frozenlist.pyx. The.pyxfile is still included in the wheels.Are there changes in behavior for the user?
The
.cppfile is not used at runtime, and even for debugging the.pyxfile should be much more useful, since the.cppfile is dense, verbose, generated code.Related issue number
N/A
Checklist
CONTRIBUTORS.txtN/A, too trivialCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.