Skip to content

Use SPDX license expression#639

Merged
bdraco merged 3 commits intoaio-libs:masterfrom
cdce8p-forks:master
Apr 17, 2025
Merged

Use SPDX license expression#639
bdraco merged 3 commits intoaio-libs:masterfrom
cdce8p-forks:master

Conversation

@cdce8p
Copy link
Copy Markdown
Contributor

@cdce8p cdce8p commented Mar 23, 2025

What do these changes do?

SSIA

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modifications, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep the list in alphabetical order, the file is sorted by name.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

webknjaz
webknjaz reviewed Apr 1, 2025
View reviewed changes
webknjaz
webknjaz requested changes Apr 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, PEP 639 deprecates the trove classifiers, so their removal should be coupled with SPDX.

@cdce8p
Copy link
Copy Markdown
Contributor Author

cdce8p commented Apr 10, 2025

Additionally, PEP 639 deprecates the trove classifiers, so their removal should be coupled with SPDX.

Updated the changelog and removed the classifier. Do note though that setuptools will continue to use the License field in the project metadata until the metadata is moved to pyproject.toml. If you like, I can do that in a followup.

@cdce8p cdce8p requested a review from webknjaz April 10, 2025 13:08
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (c28f32d) to head (134ab1c).
Report is 36 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   96.94%   93.85%   -3.10%     
==========================================
  Files          16       10       -6     
  Lines        1278      635     -643     
  Branches       90       46      -44     
==========================================
- Hits         1239      596     -643     
- Misses         14       15       +1     
+ Partials       25       24       -1
Flag Coverage Δ
CI-GHA 93.70% <ø> (-3.10%) ⬇️
MyPy 72.66% <ø> (-0.04%) ⬇️
OS-Linux 99.20% <ø> (-0.49%) ⬇️
OS-Windows 99.20% <ø> (-0.40%) ⬇️
OS-macOS 99.20% <ø> (ø)
Py-3.10.11 99.20% <ø> (-0.20%) ⬇️
Py-3.10.16 99.20% <ø> (-0.49%) ⬇️
Py-3.11.11 99.20% <ø> (-0.49%) ⬇️
Py-3.11.9 99.20% <ø> (-0.20%) ⬇️
Py-3.12.9 99.20% <ø> (-0.35%) ⬇️
Py-3.13.2 99.20% <ø> (-0.35%) ⬇️
Py-3.13.3t 99.20% <ø> (?)
Py-3.9.13 99.20% <ø> (-0.20%) ⬇️
Py-3.9.21 99.20% <ø> (-0.49%) ⬇️
Py-pypy7.3.16 98.41% <ø> (ø)
Py-pypy7.3.19 98.41% <ø> (ø)
VM-macos-latest 99.20% <ø> (ø)
VM-ubuntu-latest 99.20% <ø> (-0.49%) ⬇️
VM-windows-latest 99.20% <ø> (-0.40%) ⬇️
pytest 99.20% <ø> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@webknjaz
Copy link
Copy Markdown
Member

webknjaz commented Apr 17, 2025

@cdce8p I'm not yet ready to switch to PEP 621. But we could give it a try and see..

@bdraco bdraco merged commit d8e4a82 into aio-libs:master Apr 17, 2025
79 of 84 checks passed
@cdce8p cdce8p mentioned this pull request Apr 17, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz approved these changes

@bdraco bdraco bdraco approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cdce8p @webknjaz @bdraco