Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 1 1
Lines 67 67
Branches 11 11
=======================================
Hits 63 63
Misses 2 2
Partials 2 2
Continue to review full report at Codecov.
|
Kentzo
reviewed
Jul 1, 2018
asvetlov
requested changes
Jul 5, 2018
Member
asvetlov
left a comment
There was a problem hiding this comment.
Thank you for the PR.
Sorry for late response, I have very limited spare time now.
Please address my comments (or describe why I'm wrong).
asvetlov
approved these changes
Sep 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading async_timeout, I got some errors because I am running mypy with some stricter options (e.g.,
--no-implicit-optional,--disallow-any-generics). There's related discussion in python/mypy#5260, but in general I believe it's a good practice for libraries to be mypy-clean under strict settings, so that users can use those settings safely.This PR adds a mypy.ini file with a number of stricter options and fixes the issues found in current async_timeout code.
Also, thanks for being so quick in adding typing and
py.typedto your package!