Fix annotations on __exit__ and __aexit__#274
Merged
Dreamsorcerer merged 3 commits intoaio-libs:masterfrom Dec 19, 2021
Merged
Conversation
All parameters should be Optional, because they're None when no exception is thrown.
Contributor
Author
|
I'll add a changelog entry in a minute. |
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 118 118
Branches 20 20
=========================================
Hits 118 118
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
for more information, see https://pre-commit.ci
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Jan 8, 2022
Fix tests. 4.0.2 (2021-12-20) ================== Misc ---- - `#259 <https://github.com/aio-libs/async-timeout/issues/259>`_, `#274 <https://github.com/aio-libs/async-timeout/issues/274>`_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All parameters should be Optional, because they're None when no exception is thrown.
What do these changes do?
Change some type annotations.
Are there changes in behavior for the user?
Potentially if they are using a type checker. I found this because I made pyanalyze reject
withstatements using objects that do not meet the ContextManager protocol. Other type checkers may be less strict.Related issue number
None.
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.