Use AppKey#621

Merged

Dreamsorcerer merged 6 commits intomasterfrom

Nov 19, 2023

Member

Dreamsorcerer commented Nov 11, 2023

No description provided.


          Use AppKey

a565318

Dreamsorcerer mentioned this pull request

** 3.9 Beta testing ** aio-libs/aiohttp#7675

Closed

8 tasks

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_watch.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

setup.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved


          Apply suggestions from code review

6e9f84b

codecov bot commented Nov 19, 2023 •

edited

Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (508799b) 92.11% compared to head (9f54a43) 91.28%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
aiohttp_devtools/runserver/serve.py	70.37%	6 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   92.11%   91.28%   -0.83%     
==========================================
  Files          12       12              
  Lines         799      815      +16     
  Branches      136      140       +4     
==========================================
+ Hits          736      744       +8     
- Misses         41       47       +6     
- Partials       22       24       +2

Flag	Coverage Δ
unit	`91.16% <72.41%> (-0.83%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dreamsorcerer commented

View reviewed changes

aiohttp_devtools/logs.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

aiohttp_devtools/runserver/serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

aiohttp_devtools/runserver/serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

aiohttp_devtools/runserver/serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

aiohttp_devtools/runserver/serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

aiohttp_devtools/runserver/serve.py Outdated Show resolved Hide resolved

Dreamsorcerer added 2 commits

November 19, 2023 14:37


          Update test_runserver_serve.py

a123ce2


          Apply suggestions from code review

acf29ce

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer commented

View reviewed changes

tests/test_runserver_serve.py Outdated Show resolved Hide resolved

Dreamsorcerer added 2 commits

November 19, 2023 14:39


          Apply suggestions from code review

7fcc421


          Update test_runserver_serve.py

9f54a43

Dreamsorcerer merged commit 38c22c7 into master

Dreamsorcerer deleted the aiohttp-3.9 branch

November 19, 2023 15:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet