Conversation
bdraco
approved these changes
Sep 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.11 #9319 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 108 108
Lines 34975 34980 +5
Branches 4177 4177
=======================================
+ Hits 34204 34209 +5
Misses 574 574
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9309 as merged into master (e402833).
What do these changes do?
The port was incorrectly being passed in the
hostfield toURL.buildwhen theHostheader included theportAre there changes in behavior for the user?
Calling
BaseRequest.urlwill not fail with yarl 1.13.0+ when thehostheader has a portIs it a substantial burden for the maintainers to support this?
no
Related issue number
fixes #9307