Skip to content

[PR #8680/4f41d05 backport][3.10] Fix close race that prevented the close code from reaching the client#8686

Merged
bdraco merged 1 commit into3.10from
patchback/backports/3.10/4f41d05e1a1340303a92e77a166646af370291e8/pr-8680
Aug 12, 2024
Merged

[PR #8680/4f41d05 backport][3.10] Fix close race that prevented the close code from reaching the client#8686
bdraco merged 1 commit into3.10from
patchback/backports/3.10/4f41d05e1a1340303a92e77a166646af370291e8/pr-8680

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Aug 12, 2024

(cherry picked from commit 4f41d05)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 12, 2024
@bdraco bdraco changed the title Fix close race that prevented the close code from reaching the client (#8680) [PR #8680/4f41d05 backport][3.10] Fix close race that prevented the close code from reaching the client Aug 12, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (8c686e6) to head (13db6d5).
Report is 210 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8686      +/-   ##
==========================================
- Coverage   97.72%   97.70%   -0.03%     
==========================================
  Files         108      108              
  Lines       34015    34050      +35     
  Branches     4047     4048       +1     
==========================================
+ Hits        33241    33268      +27     
- Misses        577      585       +8     
  Partials      197      197              
Flag Coverage Δ
CI-GHA 97.60% <100.00%> (-0.03%) ⬇️
OS-Linux 97.28% <100.00%> (-0.02%) ⬇️
OS-Windows 94.80% <100.00%> (-0.02%) ⬇️
OS-macOS 96.94% <100.00%> (-0.03%) ⬇️
Py-3.10.11 97.04% <100.00%> (+2.42%) ⬆️
Py-3.10.14 96.99% <100.00%> (-0.03%) ⬇️
Py-3.11.9 97.23% <100.00%> (-0.03%) ⬇️
Py-3.12.4 97.33% <100.00%> (-0.03%) ⬇️
Py-3.8.10 94.42% <100.00%> (-0.02%) ⬇️
Py-3.8.18 96.77% <100.00%> (-0.03%) ⬇️
Py-3.9.13 96.92% <97.82%> (-0.03%) ⬇️
Py-3.9.19 96.78% <97.82%> (-0.13%) ⬇️
Py-pypy7.3.16 96.46% <100.00%> (-0.03%) ⬇️
VM-macos 96.94% <100.00%> (-0.03%) ⬇️
VM-ubuntu 97.28% <100.00%> (-0.02%) ⬇️
VM-windows 94.80% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 12, 2024 14:40
@bdraco bdraco merged commit 50efb2a into 3.10 Aug 12, 2024
@bdraco bdraco deleted the patchback/backports/3.10/4f41d05e1a1340303a92e77a166646af370291e8/pr-8680 branch August 12, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant