Skip to content

Python3.5 compatibility#638

Closed
smurfix wants to merge 4 commits intoaio-libs:masterfrom
smurfix:master
Closed

Python3.5 compatibility#638
smurfix wants to merge 4 commits intoaio-libs:masterfrom
smurfix:master

Conversation

@smurfix
Copy link

@smurfix smurfix commented Nov 21, 2015

3.5 renames asyncio.async() to asyncio.ensure_future().
Use it (and monkeypatch asyncio for Python < 3.4.3).

On many systems, "python" is py2.7. Extend the Makefile to explicitly use "python3" et al.

@asvetlov
Copy link
Member

  1. Monkey-patching is not an option. See 335c57f for proper ensure_future usage.
  2. Makefile should not be modified. It's not used when you do install the library e.g. by pip. For development we are recommend virtual environments using (see https://github.com/KeepSafe/aiohttp/blob/master/CONTRIBUTING.rst for details)

@asvetlov asvetlov closed this Nov 22, 2015
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants