Adjust type of iscoroutine() argument#5729
Merged
webknjaz merged 1 commit intoaio-libs:masterfrom May 22, 2021
Merged
Conversation
This will be needed to make mypy pass after python/typeshed#5517 is released. The function accepts all objects, so `object` is the appropriate annotation, but `Any` is necessary for now here to make the conditional definition work with the previous type annotation.
Codecov Report
@@ Coverage Diff @@
## master #5729 +/- ##
=======================================
Coverage 97.17% 97.17%
=======================================
Files 41 41
Lines 8865 8865
Branches 1425 1425
=======================================
Hits 8615 8615
Misses 133 133
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be needed to make mypy pass after python/typeshed#5517 is released. The function accepts all objects, so
objectis the appropriate annotation, butAnyis necessary for now here to make the conditional definition work with the previous type annotation.What do these changes do?
Minor change in type annotation
Are there changes in behavior for the user?
No
Related issue number
I don't think this change requires an issue or changelog entry, but happy to provide one if you disagree.