Drain response after every chunk write in StaticRoute.#501
Closed
jashandeep-sohi wants to merge 1 commit intoaio-libs:masterfrom
Closed
Drain response after every chunk write in StaticRoute.#501jashandeep-sohi wants to merge 1 commit intoaio-libs:masterfrom
jashandeep-sohi wants to merge 1 commit intoaio-libs:masterfrom
Conversation
Member
|
Agree in general. But please take a look on #398 -- sendfile can solve the issue even better. |
Contributor
Author
|
Yes, I'm already working on I'll post a first draft soon. |
Member
|
Fixed by #503 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shouldn't the handler for
StaticRoutes give control over to the event loop after writing each chunk, so that the event loop doesn't block? Or, am I missing something?