Skip to content

#461: Don't forget to pass data argument forward#462

Closed
kxepal wants to merge 1 commit intoaio-libs:masterfrom
kxepal:issue/461
Closed

#461: Don't forget to pass data argument forward#462
kxepal wants to merge 1 commit intoaio-libs:masterfrom
kxepal:issue/461

Conversation

@kxepal
Copy link
Copy Markdown
Member

@kxepal kxepal commented Aug 11, 2015

No description provided.

@kxepal
Copy link
Copy Markdown
Member Author

kxepal commented Aug 11, 2015

Not sure if there is need to duplicate signatures from ClientSession there, so open for comments.

@asvetlov
Copy link
Copy Markdown
Member

I'm ok with just dropping data parameter.

Ideally it would be cool to have full signatures in our shortcuts.
I don't afraid code duplication but we need tests that make sure signatures are match.

@asvetlov
Copy link
Copy Markdown
Member

I've merged it into 0.17 branch, I believe we should publish buxfix release with the change.

@asvetlov asvetlov closed this Aug 11, 2015
@lock
Copy link
Copy Markdown

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants