Merged
Conversation
asvetlov
requested changes
Sep 19, 2016
Member
asvetlov
left a comment
There was a problem hiding this comment.
Makes sense but please fix tests first.
Contributor
Author
|
Sorry, tests fixed. |
Member
|
Would you update CHANGES as well? |
Contributor
Author
|
Done |
Member
|
Looks like the robot still don't want to accept your PR 😄 |
Current coverage is 98.34% (diff: 100%)@@ 1.0 #1190 diff @@
==========================================
Files 29 29
Lines 6534 6529 -5
Methods 0 0
Messages 0 0
Branches 1095 1094 -1
==========================================
- Hits 6426 6421 -5
Misses 56 56
Partials 52 52
|
Contributor
Author
|
Merge it, before they change their mind :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
It just removes
debugsetting from gunicorn worker wich cause error when it differs fromapp.debug