fix: Incorrect return type annotations of DockerImages methods#909
Merged
asvetlov merged 5 commits intoaio-libs:mainfrom Nov 20, 2024
Merged
fix: Incorrect return type annotations of DockerImages methods#909asvetlov merged 5 commits intoaio-libs:mainfrom
DockerImages methods#909asvetlov merged 5 commits intoaio-libs:mainfrom
Conversation
DockerImages.build(), DockerImages.pull(), DockerImages.push() methods' incorrect return type declarations
DockerImages.build(), DockerImages.pull(), DockerImages.push() methods' incorrect return type declarationsDockerImages
DockerImagesDockerImages methods
6f5a814 to
24c3ad0
Compare
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
=======================================
Coverage 80.66% 80.66%
=======================================
Files 24 24
Lines 1443 1443
Branches 206 206
=======================================
Hits 1164 1164
Misses 187 187
Partials 92 92 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix incorrect type annotations for the methods calling
_handle_response()in theaiodocker/images.pyfile.DockerImages.build()DockerImages.push()DockerImages.pull()Are there changes in behavior for the user?
Users will be able to know the correct return type when running these APIs with stream=False (the default behavior).
Related issue number
None
Checklist
Unit tests for the changes existCONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.