fix: remove outdated codes that use 'AsyncCM' interface#874
Merged
achimnol merged 4 commits intoaio-libs:mainfrom Jul 5, 2024
Merged
fix: remove outdated codes that use 'AsyncCM' interface#874achimnol merged 4 commits intoaio-libs:mainfrom
achimnol merged 4 commits intoaio-libs:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
==========================================
+ Coverage 81.14% 81.19% +0.05%
==========================================
Files 24 24
Lines 1421 1420 -1
Branches 253 253
==========================================
Hits 1153 1153
+ Misses 175 174 -1
Partials 93 93 ☔ View full report in Codecov by Sentry. |
achimnol
requested changes
Jul 5, 2024
Member
achimnol
left a comment
There was a problem hiding this comment.
Let's add type annotation to the method so that it could be type-checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up #861 #850
_AsynCMinterface has a docker query coroutine as an attribute and #861 allowed the coroutine to be closed.#850 removed the
_AsynCMinterface but there is still remaining codes that try to call the method of the interface.Let's remove it.
Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.