Add support for Docker context endpoints#854
Merged
achimnol merged 15 commits intoaio-libs:mainfrom Dec 14, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
- Coverage 81.54% 79.91% -1.64%
==========================================
Files 24 24
Lines 1447 1588 +141
Branches 194 211 +17
==========================================
+ Hits 1180 1269 +89
- Misses 189 239 +50
- Partials 78 80 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
achimnol
reviewed
May 21, 2024
Member
achimnol
left a comment
There was a problem hiding this comment.
Could we add some test cases by providing mocked docker client configurations?
Member
|
Since there is no response from the original author, I'll redo the work as a preparation for #982. |
5 tasks
for more information, see https://pre-commit.ci
Member
|
Confirmed working with manual tests using: $ docker context create testing --docker "host=tcp://127.0.0.1:8812" --description="dummy"
$ docker use testing
$ python -m asyncio
...
>>> import aiodocker
>>> docker = aiodocker.Docker()
>>> await docker.images.list()
...
aiodocker.exceptions.DockerError: [900] Cannot connect to Docker Engine via tcp://127.0.0.1:8812 [Cannot connect to host 127.0.0.1:8812 ssl:default [Connect call failed ('127.0.0.1', 8812)]]
$ docker use default
$ python -m asyncio
...
>>> import aiodocker
>>> docker = aiodocker.Docker()
>>> await docker.images.list()
...
{'Containers': 0, 'Created': 1765225164, 'Id': 'sha256:... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add support for Docker context endpoints.
DOCKER_CONTEXTwill be prioritized if it is set.Are there changes in behavior for the user?
No impacts to existing users.
Related issue number
resolves #811
Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.