Skip to content

Add a new default docker socket search path#748

Merged
achimnol merged 4 commits intomasterfrom
feature/add-default-socket-search-path
May 20, 2024
Merged

Add a new default docker socket search path#748
achimnol merged 4 commits intomasterfrom
feature/add-default-socket-search-path

Conversation

@achimnol
Copy link
Copy Markdown
Member

@achimnol achimnol commented Oct 25, 2022

What do these changes do?

  • Add a new docker socket search path used by the Docker Desktop app in macOS.
  • Add support for Docker client contexts (e.g., OrbStack)

Are there changes in behavior for the user?

No impacts to existing users.

Related issue number

This PR resolves #747, #811.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder

@achimnol
Copy link
Copy Markdown
Member Author

I'm going to conclude this PR now and let a PyCon US sprint participant to do the work for context-path support.

@achimnol achimnol marked this pull request as ready for review May 20, 2024 15:29
@achimnol achimnol enabled auto-merge (squash) May 20, 2024 15:39
@achimnol achimnol merged commit 32fe691 into master May 20, 2024
@achimnol achimnol deleted the feature/add-default-socket-search-path branch May 20, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the docker socket path used by Docker Desktop for Mac

1 participant