Skip to content

Adds force parameter to volumes delete#690

Merged
achimnol merged 9 commits intoaio-libs:masterfrom
GitHK:add-force-volume-delete
May 20, 2024
Merged

Adds force parameter to volumes delete#690
achimnol merged 9 commits intoaio-libs:masterfrom
GitHK:add-force-volume-delete

Conversation

@GitHK
Copy link
Copy Markdown
Contributor

@GitHK GitHK commented Feb 16, 2022

What do these changes do?

  • Adds missing optional force parameter to DockerVolume.delete().
  • When deleting volumes in tests check that these no longer exist.

Are there changes in behavior for the user?

No user impact is expected.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@GitHK
Copy link
Copy Markdown
Contributor Author

GitHK commented Feb 16, 2022

@asvetlov I'm not sure what is happening with the windows CI on python 3.9 Looks like it times out when pulling python:latest. Any suggestion to fix this?

Otherwise I would mark the PR ready for review.

@asvetlov asvetlov changed the title Adds foce parameter to volumes delete Adds force parameter to volumes delete Feb 16, 2022
@achimnol achimnol marked this pull request as ready for review May 20, 2024 16:19
@achimnol achimnol enabled auto-merge (squash) May 20, 2024 19:39
@achimnol achimnol merged commit b252703 into aio-libs:master May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants