Skip to content

Use query params#660

Merged
achimnol merged 3 commits intoaio-libs:masterfrom
93578237:q0w-patch-1
May 20, 2024
Merged

Use query params#660
achimnol merged 3 commits intoaio-libs:masterfrom
93578237:q0w-patch-1

Conversation

@93578237
Copy link
Copy Markdown
Contributor

@93578237 93578237 commented Dec 9, 2021

Starting container with non-empty request body was deprecated since API v1.22 and removed in v1.24
ref: https://docs.docker.com/engine/api/v1.41/#operation/ContainerStart

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the changes folder
    • name it <issue_id>.<type> for example (588.bug)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Starting container with non-empty request body was deprecated since API v1.22 and removed in v1.24
ref: https://docs.docker.com/engine/api/v1.41/#operation/ContainerStart
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (f1dbdc3) to head (c37f14d).
Report is 21 commits behind head on master.

Current head c37f14d differs from pull request most recent head 19698a8

Please upload reports for the commit 19698a8 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   81.40%   81.26%   -0.15%     
==========================================
  Files          23       23              
  Lines        1377     1377              
  Branches      259      259              
==========================================
- Hits         1121     1119       -2     
- Misses        172      175       +3     
+ Partials       84       83       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achimnol achimnol merged commit 35bc605 into aio-libs:master May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants