Skip to content

Implement docker exec protocol#415

Merged
asvetlov merged 24 commits intomasterfrom
exec
Mar 23, 2020
Merged

Implement docker exec protocol#415
asvetlov merged 24 commits intomasterfrom
exec

Conversation

@asvetlov
Copy link
Copy Markdown
Member

@asvetlov asvetlov commented Mar 20, 2020 •
edited
Loading

Thanks, @hirokiky, and @tbeadle for their initial work on the issue.

The usage looks like this:

    exe = await shell_container.exec(
        stdout=True, stderr=True, stdin=True, tty=True, cmd=["python"],
    )
    async with exe.start(detach=False, tty=True) as stream:
        await stream.write_in("print('Hello')")
        assert await stream.read_out() == (1, b"Hello\r\n")  # 1 for stdout

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2020 •
edited
Loading

Codecov Report

Merging #415 into master will decrease coverage by 0.07%.
The diff coverage is 88.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   87.61%   87.54%   -0.08%     
==========================================
  Files          19       21       +2     
  Lines         985     1172     +187     
==========================================
+ Hits          863     1026     +163     
- Misses        122      146      +24
Impacted Files Coverage Δ
aiodocker/containers.py 88.26% <81.25%> (-2.41%) ⬇️
aiodocker/stream.py 86.66% <86.66%> (ø)
aiodocker/execs.py 93.61% <93.61%> (ø)
aiodocker/docker.py 90.25% <100.00%> (-0.43%) ⬇️
aiodocker/utils.py 78.45% <100.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b78921...b83616b. Read the comment docs.

@asvetlov asvetlov merged commit 9381476 into master Mar 23, 2020
@asvetlov asvetlov deleted the exec branch March 23, 2020 12:00
This was referenced Mar 25, 2020
Closed
Closed
Closed
@g-k g-k mentioned this pull request Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asvetlov