Remove loop= param from asyncio.sleep() to fix tests on Python 3.10#96
Merged
saghul merged 2 commits intoaio-libs:masterfrom May 15, 2021
Merged
Remove loop= param from asyncio.sleep() to fix tests on Python 3.10#96saghul merged 2 commits intoaio-libs:masterfrom
saghul merged 2 commits intoaio-libs:masterfrom
Conversation
Contributor
Author
|
I've also attempted enabling GHA testing on 3.10. |
Contributor
|
Looks like we need to install the wheel package to make sure building works. |
Contributor
Author
|
Yeah, I'm guessing this is because either some of the low-level stuff (pip?) or GHA hasn't been yet all synced for 3.10 deprecations. |
Contributor
Author
|
Windows seems to be unhappy but I don't really know how to fix it. |
Contributor
|
Let's exclude it for now. Linux and macOS pass, which is a good indication :-) I think you can add a "excludes" section to the build matrix to skip 3.10 on Windows. |
Contributor
Author
|
Let's try that but I think the wheel install stage could be causing the hangs on 3.8/3.9 jobs too. |
saghul
approved these changes
May 15, 2021
Contributor
|
Not sure why Windows is getting stuck on Python 3.8/3.9 but that's not related to your PR. Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #95