Fix resolver garbage collection during pending queries#211
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 97.31% 97.69% +0.37%
==========================================
Files 3 3
Lines 559 564 +5
Branches 38 38
==========================================
+ Hits 544 551 +7
+ Misses 8 7 -1
+ Partials 7 6 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Converts
_callbackfrom a@staticmethodto an instance method so that the callback holds a strong reference to the resolver instance. This prevents the resolver from being garbage collected while queries are pending.Are there changes in behavior for the user?
Previously, queries on temporary resolvers would fail:
Now this pattern works correctly because the future's callback keeps the resolver alive until the query completes.
Related issue number
Fixes #209
Checklist