Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 96.76% 97.79% +1.02%
==========================================
Files 3 3
Lines 557 545 -12
Branches 36 33 -3
==========================================
- Hits 539 533 -6
+ Misses 10 6 -4
+ Partials 8 6 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@webknjaz @Dreamsorcerer I just reverted those ignore blocks. |
Contributor
|
Nvm, I forgot the loop will give us independent callbacks anyway. 👍 |
saghul
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes are meant to speedup socket callbacks for the read and write file descriptors making the dns resolver run a bit smoother.
Are there changes in behavior for the user?
Removed some internal flags related to read and write but I don't think anybody is ever going to use them to begin with.
Related issue number
Checklist