Fix release workflow for breaking changes in upload/download artifact#148
Merged
Fix release workflow for breaking changes in upload/download artifact#148
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 3 3
Lines 311 311
Branches 24 24
=======================================
Hits 288 288
Misses 12 12
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
webknjaz
reviewed
May 2, 2025
| needs: [build_wheels, build_sdist] | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write # IMPORTANT: mandatory for making GitHub Releases |
Member
There was a problem hiding this comment.
This privilege looks unused, FYI.
Member
Author
There was a problem hiding this comment.
I wasn’t entirely sure whether we’re planning to stick with the GitHub release workflow or move toward just pushing tags, happy to align either way.
Member
There was a problem hiding this comment.
My typical workflow outside of aio-libs is a bit different, but also publishes to GH releases. I'd love to eventually migrate to that. But for now, whatever you're going to set up will be good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also switched it over to trusted publishing since its already set up.