Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 92.60% 92.55% -0.05%
==========================================
Files 3 3
Lines 311 336 +25
Branches 24 23 -1
==========================================
+ Hits 288 311 +23
- Misses 12 15 +3
+ Partials 11 10 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dreamsorcerer
commented
Apr 5, 2025
Dreamsorcerer
commented
Apr 5, 2025
Member
Author
|
I think the final type error should be fixed in the next mypy release, so will wait a couple more weeks for that. |
bdraco
reviewed
May 1, 2025
Member
|
Sorry for the conflicts, hopefully I fixed them correctly. |
Member
|
I think we can merge this and add an ignore for now, than open a new PR to review the ignore dependent on the mypy release |
bdraco
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.