Add Winloop as a valid EventLoop#116
Merged
saghul merged 3 commits intoaio-libs:masterfrom Mar 22, 2024
Vizonex:master
Merged
Conversation
Contributor
|
Nice! Could you add a test here that runs on winloop? |
Member
Author
|
On Wed, Mar 20, 2024 at 9:55 PM Saúl Ibarra Corretgé < ***@***.***> wrote:
Nice! Could you add a test here that runs on winloop?
—
Reply to this email directly, view it on GitHub
<#116 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3K7GGV45XZ7NX4CXNMST7TYZJDY5AVCNFSM6AAAAABFAS56NSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGA4TKOBTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
I probably could in a bit.
|
Member
Author
|
One Little thing I added was also uvloop which works on other platforms excluding windows might be smart to add so I included it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I recently tried to see if
winloopwould be another valid option since it is not tied to theProctorEventLoopin any way shape or form and I was able to spin up a quick unittest once I modified aiodns's dns resolver to work with my library.btw I am the main developer of winloop.