Well Agp 9 is quite a bit of a change#392
Conversation
|
I think I will base my future work on this branch downstream since something like this has to be done in time anyway. So I wanted to save you the hassle. I can also migrate my existing PRs if you look at this first. |
|
I think we have to look over the proguard rules again. And it would be nice to split the desktop app as well into app and library so that it the same for all architectures, android, iOS and desktop |
|
I hadn't had the time or nerves to tackle this yet so thank you for doing it! A couple of things that we have to keep in mind:
|
|
Will do after work. What is you opinion on renaming the composdApp? I definitely get why you didn't do it 😐 |
|
Since we are already doing packaging stuff, I added desktop output including, rpm, deb, msi, appImage I verified that builds do in fact work and fastlane is configured now hopefully correctly aswell. The changes on we have to do in fdroid repo are ready, but since this isn't merged yet i will hold of on them |
|
@aimok04 i think it is in a decent state now. |
I mean it's of course a big change and PRs would need to be changed of course but I think its better to stick to the official recommendation so I think it's a good change in general. I'll merge this first, so it would be great if you could update your PRs once this is merged. Thanks the other changes, I think they're all good additions. |
|
Oh and I'll need to update the weblate project |
|
Just letting you know Next up will be koin dependency injection and starting room db implementation which are both ready but unfortunatly are very dependent on each other and on this. So after this is merged and the other PRs are adjusted I will make a koin + room db pr (both in one allows me to do refactoring from that point instead of building my own complicated git tree) after which it will be better handleable with one PR per addition. |
|
Also tested compilation on mac OS for iOS - works fine! |
This PR simply updates all dependencies and moves to jvm 21 since filekit needs this.
I followed https://blog.jetbrains.com/kotlin/2026/01/update-your-projects-for-agp9/
And renamend the composeApp to shared like in the video i like this more.
The android app is now also a standalone application that uses the shared/androidMain library.
This should be tested extensibly and I hope I did not forget anything. I cannot test IOS as far as I know without a mac, so idk.
Deskop and android seem to work correctly.