Add meal type selection picker and dialog#386
Merged
Conversation
Owner
Contributor
Author
|
Somewhat yes if we decide to completly replace it but then I should delete the old Input file as well. |
Contributor
Author
|
Now removed the old search field. I'll close the other ones since I find this way nicer. |
This was referenced Apr 18, 2026
…in ColorPickerField
…MealTypePickerField bottom sheet
Owner
|
Thanks! |
Contributor
Author
|
SegmentedListItem is a nice change |
Owner
|
Thanks! Just noticed that you already updated your fork - I did a mistake which lead to the app not compiling so I reverted the original |
Contributor
Author
|
@aimok04 well yes I just came back home at night and saw the merged PR and then it was the last thing before being to tired. I refetched and rebased them again :D thanks for letting me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a kinda large Pr since I needed to add 2 new Form Field types, but I think you will like it.
Added a new FormField type MealTypePickerField which currently replaces the MealTypeSearchField which could not probably be removed. This opens a bottom sheet allow you to select the meal-type by just clicking.
The rational behin this is that most of the people will reasonably only have a few meal-types
Add a new MealTypeCreationAndEditDialog which allows the app to create, edit and delete new meal types. This is integrated in to the new PickerField as well as i could.
The dialog needed a color chooser and a time field both of which were added
Now here is a complete show of the new stuff
screen-20260416-221927-1776370717452.mp4