replace reentry by importlib.metadata#4960
Closed
ltalirz wants to merge 3 commits intoaiidateam:developfrom
Closed
replace reentry by importlib.metadata#4960ltalirz wants to merge 3 commits intoaiidateam:developfrom
ltalirz wants to merge 3 commits intoaiidateam:developfrom
Conversation
Note: this is a quick port of an earlier fix intended for testing; pre-commit still fails because of one missing feature + we may want to clean up the codebase a bit.
dev-zero
reviewed
Jun 4, 2021
dev-zero
reviewed
Jun 4, 2021
Co-authored-by: Tiziano Müller <tm@dev-zero.ch>
Member
Author
|
thanks! |
Member
|
Hey @ltalirz, just to note, as of python 3.10 (https://docs.python.org/3.10/library/importlib.metadata.html#entry-points) and already implemented in the As an example, I have implemented this in another of my packages: executablebooks/MyST-NB@a4c21b1 |
Member
Author
|
superseded by #5058 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is a quick port of an earlier fix intended for testing;
pre-commit still fails because of one missing feature + we may want to
clean up the codebase a bit.