Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
=======================================
Coverage 72.15% 72.15%
=======================================
Files 18 18
Lines 1616 1616
=======================================
Hits 1166 1166
Misses 450 450
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I want to give it a manual test before merging, but otherwise should be ready. |
1639cb9 to
06579c5
Compare
This was referenced Apr 3, 2025
aba1fa4 to
07d9011
Compare
Open
EVENT_TYPE_CLOSED_NO_WRITE was added in watchdog=5.0 Citing from the inotify(7) manpage: IN_CLOSE_NOWRITE is fired when a file that was opened in read-only mode was closed. Since we only watch for events that modify files inside the app git repo, we can ignore this event.
07d9011 to
81ac523
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 5.0 was released recently, see changelog. We want to move to this since the library is now fully typed, which will help us towards #363.
There is one change in the code to ignore the newly added
EVENT_TYPE_CLOSED_NO_WRITEwhich we do not care about, as written in the commit message: