feat: improve devcontainer configuration#230
Merged
Merged
Conversation
bpapaspyros
commented
Feb 11, 2025
Member
|
Sorry I'll get to that at some point... |
domire8
reviewed
Feb 20, 2025
domire8
previously approved these changes
Feb 20, 2025
bpapaspyros
commented
Feb 20, 2025
domire8
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by adding clangd and clang-format in devcontainer to facilitate the development experience.
Review guidelines
Estimated Time of Review: 5 minutes
One thing to note is that compile commands for the proto messages are correctly generated, but since the corresponding headers will not exist until
makeis actually invoked and complete, they will appear as missing references.I added a build option for the
generate_compile_commandsscript to optionally (but by default) build the project too. It's going to be taking some time if we invoke the build in single thread.Checklist before merging: