feat: add integrate method with offset to Cartesian twist#212
Merged
Conversation
domire8
commented
Jan 9, 2025
eeberhard
previously approved these changes
Jan 9, 2025
eeberhard
left a comment
Member
There was a problem hiding this comment.
Those additional overloads are good with me, thanks!
eeberhard
reviewed
Jan 9, 2025
eeberhard
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by adding methods that also take an initial pose for the integration of a Cartesian twist. I didn't go with an argument that has a default value
CartesianPose()because then it becomes complicated to know when the argument was not provided or the provided argument is empty and we should throw an exception.Review guidelines
Estimated Time of Review: 3 minutes
Checklist before merging: