feat: Integrate min distance#167
Merged
Merged
Conversation
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
…nology/control-libraries into feat/collision-detection-robot
domire8
reviewed
Mar 19, 2024
…ogy/control-libraries into feat/integrate-min-distance
domire8
reviewed
Mar 19, 2024
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
domire8
reviewed
Apr 2, 2024
Co-authored-by: Dominic Reber <71256590+domire8@users.noreply.github.com>
…ogy/control-libraries into feat/integrate-min-distance
domire8
reviewed
Apr 3, 2024
domire8
left a comment
Member
There was a problem hiding this comment.
Wrong format in Model.cpp and test_collisions.cpp. You can select the changes you made and then right click and Format Selection in the devcontainer
eeberhard
reviewed
Apr 5, 2024
eeberhard
left a comment
Member
There was a problem hiding this comment.
Looking very good! Just some nitpicks
Co-authored-by: Enrico Eberhard <32450951+eeberhard@users.noreply.github.com>
…ogy/control-libraries into feat/integrate-min-distance
eeberhard
previously approved these changes
Apr 8, 2024
…ogy/control-libraries into feat/integrate-min-distance
domire8
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by calculating the minimum distance between every robot link and return a matrix sized
number of jointsbynumber of jointswhere at element(i, j), it contains the minimum distance betweenlink iandlink j. In addition to that, it also implements the pybindings to expose this method through python and accordingly will return a numpy array.Review guidelines
Estimated Time of Review: 7 minutes
Checklist before merging: