Misc fixes and partial implementation of Pod component#90
Merged
Conversation
* Partially implements Pod component. With this commit pods without scheduling gates can be created. * Enables Pod component in the PodClique reconciler. * Fixed HPA component which now correctly sets the target resource ref. * Fixed service component, which now creates a headless service. * Introduced some convenient functions. * Changed the pgs-replica-index label key as it was not as per allowed conventions. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
* Added missing license headers to new files * Fixed linting issues * Fixed formatting issues Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
renormalize
reviewed
Jun 17, 2025
renormalize
approved these changes
Jun 17, 2025
renormalize
left a comment
Contributor
There was a problem hiding this comment.
thanks for bringing in these changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.