Conversation
67d87dd to
0c740b0
Compare
11ef4d7 to
e5d38d4
Compare
b6d0b05 to
4967866
Compare
Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
* Updated API removing pointer types where not required. * Added code in cmd/main.go to call RegisterWebhooks. * Refactored validation webhook for PodGangSet. Signed-off-by: Madhav Bhargava <madhav.bhargava@sap.com>
7e03550 to
fd2a0b1
Compare
Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
unmarshall
approved these changes
Dec 16, 2024
| func (h *Handler) Handle(ctx context.Context, req admission.Request) admission.Response { | ||
| panic("implement me") | ||
| log := h.logger.WithValues("name", req.Name, "namespace", req.Namespace, "resource", fmt.Sprintf("%s/%s", req.Kind.Group, req.Kind.Kind), "operation", req.Operation, "user", req.UserInfo.Username) | ||
| log.V(1).Info("Grove validation webhook invoked") |
Collaborator
There was a problem hiding this comment.
Suggested change
| log.V(1).Info("Grove validation webhook invoked") | |
| log.V(1).Info("PodGangSet validation webhook invoked") |
Collaborator
There was a problem hiding this comment.
This has already been done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.