Implement the init container.#88
Merged
Merged
Conversation
0a8343b to
98ead78
Compare
* Implement the init container. The init container currently waits for all `PodClique`s to be ready simultaneously to the best of its knowledge before exiting. * Add `github.com/NVIDIA/grove/operator/client` to `operator/go.mod` so the init container's main package can find the path of the client code. * Change the `Role` to not constrain to specific `ResourceNames` so the informers can `List` all `PodClique`s in a namespace. Previously, only the `PodCliques` that are created as a part of the `PodGangSet` could be `get`, `list`, and `watch`-ed. This approach of restricting which `ResourceNames` does not work with informers, since they require being able to list all resources in the specified namespace. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
98ead78 to
7e3bad3
Compare
unmarshall
reviewed
Jun 18, 2025
* Renamed initc config fields. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
* Reorganize `initc/` package to adhere to the convention set for the `operator/`. * Merge `operator/Dockerfile` and `operator/initc/Dockerfile`. Each image can be built seperately by specifying the target. * Use `internal/logger` and `internal/version` pacakges in `initc/`. * Modify `Makefile` targets, and `operator/hack/docker-build.sh` to build both images. * Enhance `skaffold.yaml` to build `grove-initc`. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
unmarshall
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the init container. The init container currently waits for all
PodCliques to be ready simultaneously to the best of its knowledge before exiting.Change the Role to not constrain to specific
ResourceNamesso the informers canListallPodCliques in a namespace.