Enhancements to API and reconcilers#86
Merged
Merged
Conversation
* Refactored components. Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
* Fix multiple `nil` pointer panics. * Remove references to `MinReplicas` for the scaling group. * Fix miscellaneous compilation errors. * Fix test errors. * Fix `scheduler/client` Go version to `1.24.0`. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Add HPA to `getOrderedKindsForSync`. * Implemented `Delete`. * Corrected the GV of HPA to be `autoscaling/v2`. * Format code and add comments. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Fix `minReplicas` not being set in the defaulting webhook. * Fix indentation in a the pgs-defaulting-webhook-config template. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Register the HPA component with the operator registry. * Enhance the operator's `ClusterRole` to act on HPA resources. * Enhance the operator's `ClusterRole` to act on `PodCliqueScalingGroup` resources. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
…roup Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
….CliqueNames during creation Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
…ScalingGroup.Status`. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Refactors reconciliation step functions * Removes DRY by creating ReconciledObject type * Refactors PodCliqueScalingGroup reconciler and adds code to update status * Touches some files to harmonize import alias * Adds missing license headers Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
…nd `ObservedGeneration`. * Make `PodCliqueScalingGroupSpec.Replicas` and `PodCliqueScalingGroupSpec.Selector` `omitempty`. * Correct hardcoded kind values in `internal/controller/common/reconcilestatusrecorder.go`, and use the actual kind of the objects. * Introduce `recordIncompleteReconcile` in `internal/controller/podclique/reconcilespec.go`. * The `PodCliqueScalingGroup` controller reacts to Create events too, with the same filter as updates. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
…Status.Selector`. * Add `PodCliqueScalingGroupStatus.Replicas`. * Add `PodCliqueScalingGroupStatus.Selector`. * Introduce the new label `LabelPodCliqueScalingGroup` that identifies which scaling group a particular `Pod` belongs to. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
renormalize
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
CliqueNamesandStatustoPodCliqueScalingGroupcustom resource.