Skip to content

Enhancements to API and reconcilers#86

Merged
renormalize merged 18 commits into
ai-dynamo:mainfrom
unmarshall:reconcilers
Jun 12, 2025
Merged

Enhancements to API and reconcilers#86
renormalize merged 18 commits into
ai-dynamo:mainfrom
unmarshall:reconcilers

Conversation

@unmarshall

Copy link
Copy Markdown
Collaborator

This PR introduces the following changes:

  • Added CliqueNames and Status to PodCliqueScalingGroup custom resource.
  • Introduced a single component for all HPA resources (either due to ScalingConfig defined for a PodClique or ScalingConfig defined in PodCliqueScalingGroup)
  • Enhanced concurrent utility to allow slow batching
  • Fixed multiple nil pointer dereference
  • Added missing PodCliqueScalingGroup CRD to helm crds folder.
  • Added simple sample (more samples to be added in later commits)
  • Removed violation of DRY and refactored the status recorder. Now its shared code across all CRs.

unmarshall and others added 18 commits June 12, 2025 15:59
* Refactored components.

Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
* Fix multiple `nil` pointer panics.

* Remove references to `MinReplicas` for the scaling group.

* Fix miscellaneous compilation errors.

* Fix test errors.

* Fix `scheduler/client` Go version to `1.24.0`.

Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Add HPA to `getOrderedKindsForSync`.

* Implemented `Delete`.

* Corrected the GV of HPA to be `autoscaling/v2`.

* Format code and add comments.

Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Fix `minReplicas` not being set in the defaulting webhook.

* Fix indentation in a the pgs-defaulting-webhook-config template.

Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Register the HPA component with the operator registry.

* Enhance the operator's `ClusterRole` to act on HPA resources.

* Enhance the operator's `ClusterRole` to act on `PodCliqueScalingGroup` resources.

Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
…roup

Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
….CliqueNames during creation

Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
…ScalingGroup.Status`.

Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
* Refactors reconciliation step functions
* Removes DRY by creating ReconciledObject type
* Refactors PodCliqueScalingGroup reconciler and adds code to update
  status
* Touches some files to harmonize import alias
* Adds missing license headers

Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
…nd `ObservedGeneration`.

* Make `PodCliqueScalingGroupSpec.Replicas` and `PodCliqueScalingGroupSpec.Selector` `omitempty`.

* Correct hardcoded kind values in `internal/controller/common/reconcilestatusrecorder.go`, and use the actual kind of the objects.

* Introduce `recordIncompleteReconcile` in `internal/controller/podclique/reconcilespec.go`.

* The `PodCliqueScalingGroup` controller reacts to Create events too,
  with the same filter as updates.

Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
…Status.Selector`.

* Add `PodCliqueScalingGroupStatus.Replicas`.

* Add `PodCliqueScalingGroupStatus.Selector`.

* Introduce the new label `LabelPodCliqueScalingGroup` that identifies
  which scaling group a particular `Pod` belongs to.

Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
@renormalize renormalize merged commit 57d7b14 into ai-dynamo:main Jun 12, 2025
1 check passed
@unmarshall unmarshall deleted the reconcilers branch June 12, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants