Corrections in PGS components#83
Merged
Merged
Conversation
…rate headless service name Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
…`PodClique`s that belong to the `PodGangSet`. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
enabled automount for ServiceAccount token Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings in the following changes:
grove.io/podgang-namelabel as PodGang has now been de-linked with PodGangSet replicas.grove.io/podgangset/replica-indexwhich will be put on resources that are created per replica of a PodGangSet.ResourceNamesto Roles that are created per PodGangSet, limiting access to get/list pods within the same PodGangSet.AutomountServiceAccountTokento a default value of true for ServiceAccount created per PodGangSet.