Introduce make targets and charts for the development, and deployment of grove-kube-scheduler.#80
Merged
Conversation
… of `grove-kube-scheduler`. * Introduce the `deploy-local-replace` target which replaces the vanilla kube-scheduler with `grove-kube-scheduler` in the local kind cluster. * Introduce the `deploy-local-second` target to deploy the `grove-kube-scheduler` as a second scheduler in the local kind cluster. * Introduce the `Dockerfile` for the `grove-kube-scheduler`. * Introduce charts to enable running `grove-kube-scheduler` as a second scheduler. * Introduce `skaffold.yaml`. * Enhance more targets `build-%`, `docker-build-%` and corresponding shell scripts. * Add documentation on how to test the kube-scheduler plugin with the `deploy-local-replace` target. * Fix a typo in `operator/charts/templates/`. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
…mo#78. * Fix broken targets due to reorganization of the repository. * Add missing license headers. * Format code. Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
unmarshall
requested changes
May 15, 2025
Collaborator
There was a problem hiding this comment.
Thanks for the PR @renormalize. It is a comprehensive PR. I have added some review comments. Please take a look.
| @@ -0,0 +1,239 @@ | |||
| #!/usr/bin/env bash | |||
Collaborator
There was a problem hiding this comment.
why repeat this script 2 times?
Contributor
Author
There was a problem hiding this comment.
Not touching this right now as discussed in #80 (comment).
| @@ -0,0 +1,92 @@ | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
why repeat this script 2 times?
Contributor
Author
There was a problem hiding this comment.
Not touching this right now as discussed in #80 (comment).
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
Signed-off-by: Saketh Kalaga <51327242+renormalize@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce make targets and charts for the development, and deployment of
grove-kube-scheduler.Introduce the
deploy-local-replacetarget which replaces the vanilla kube-scheduler withgrove-kube-schedulerin the local kind cluster.Introduce the
deploy-local-secondtarget to deploy thegrove-kube-scheduleras a second scheduler in the local kind cluster.Introduce the
Dockerfilefor thegrove-kube-scheduler.Introduce charts to enable running
grove-kube-scheduleras a second scheduler.Introduce
skaffold.yaml.Enhance more targets
build-%,docker-build-%and corresponding shell scripts.Add documentation on how to test the kube-scheduler plugin with the
deploy-local-replacetarget.Fix a typo in
operator/charts/templates/.Fix broken targets due to reorganization of the repository in Introduced PodCliqueScalingGroup and refactored API modules #78.
Add missing license headers.
Format code.