Refine scale test delete measurements#621
Merged
shayasoolin merged 5 commits intoMay 19, 2026
Merged
Conversation
danbar2
previously approved these changes
May 19, 2026
Ronkahn21
reviewed
May 19, 2026
Ronkahn21
approved these changes
May 19, 2026
danbar2
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Removes the 5000-pod deletion scale test and changes
ScaleTest_1000to measure only the user-facing PCS delete request latency. After cascade-delete, waiting for all child resources and pods to disappear mostly measures Kubernetes API server and garbage collector behavior rather than Grove controller overhead.Adds a small regular e2e test that verifies PCS deletion cascades through the owned Grove resource tree and managed child resources.
Which issue(s) this PR fixes:
Related to #423
Special notes for your reviewer:
The scale result intentionally excludes Kubernetes cascade-cleanup latency. Cascade-delete correctness is covered by the new small e2e test instead.
Does this PR introduce a API change?
Additional documentation e.g., enhancement proposals, usage docs, etc.: