Skip to content

Refactoring operator#62

Merged
unmarshall merged 1 commit into
ai-dynamo:mainfrom
unmarshall:refactoring
Apr 12, 2025
Merged

Refactoring operator#62
unmarshall merged 1 commit into
ai-dynamo:mainfrom
unmarshall:refactoring

Conversation

@unmarshall

@unmarshall unmarshall commented Apr 12, 2025

Copy link
Copy Markdown
Collaborator
  • Operator API Changes:
    • Renamed PodGangTemplateSpec.ServiceSpec to PodGangTemplateSpec.HeadlessServiceConfig
    • Renamed PodGangSpec.Template to PodGangSpec.TemplateSpec
  • Headless service component's Delete method was not implemented. This PR includes the implementation.
  • There are other misc changes to components.
  • In helm charts, clusterrole now has additional role for deletecollection for services.
  • Added PodGang name label to PodClique and HeadlessService resources.
  • Corrected the label selector for headless service as it was not correct.

@unmarshall
misc changes
5cfa74b 
Signed-off-by: madhav bhargava <madhav.bhargava@sap.com>
@unmarshall unmarshall merged commit ccd7740 into ai-dynamo:main Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanjaychatterjee sanjaychatterjee Awaiting requested review from sanjaychatterjee sanjaychatterjee is a code owner

@dmitsh dmitsh Awaiting requested review from dmitsh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@unmarshall