use lodash func#618
Merged
oleg-kushniriov merged 2 commits intoMay 19, 2026
Merged
Conversation
danbar2
approved these changes
May 19, 2026
shayasoolin
approved these changes
May 19, 2026
a9fb562 to
5c66505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind cleanup
What this PR does / why we need it:
Replaces two custom helpers in
operator/internal/controller/common/component/utilswith their directsamber/loequivalents:MapBy(and its tests) in favor oflo.SliceToMap.MapBywas a one-to-one re-implementation; callers inlookups.goandpodgang/syncflow.gonow uselo.SliceToMapdirectly.
lo.Reduce(..., agg || …, false)fold inisStandalonePCLQwithlo.SomeBy. Same semantics, butSomeByshort-circuits on the first match instead of walking the fullslice, and the intent ("does any config contain this clique?") is expressed directly.
No behavior change. Pure refactor to lean on the upstream library and shrink the local utils surface.
Which issue(s) this PR fixes:
Fixes #567
Special notes for your reviewer:
NewSet/NewSetBywere left in place: they return the package'sSet[T] = map[T]struct{}typedef with aHasmethod, and lo has no equivalent set type — swapping them in wouldlose the named type and method.
groupPCLQsByLabel/groupPCSGsByLabelwere also left alone: they filter items missing the label and group, so a one-to-one swap tolo.GroupByisn't possible (would requirelo.GroupBy(lo.Filter(…), …), a composite rather than a direct replacement).Does this PR introduce a API change?