test(mnnvl): rewrite E2E tests for single-annotation model#583
Merged
shmuel-runai merged 3 commits intoMay 7, 2026
Merged
Conversation
- Replace Go builder functions with pre-written YAML fixtures - Add applyMNNVLYAML helper for unique resource naming - Add testMNNVLEndToEnd comprehensive test covering all layers - Streamline test suite, remove redundant tests Co-authored-by: Cursor <cursoragent@cursor.com>
shayasoolin
reviewed
May 6, 2026
- Clarify shared_cases.go comment: distinguish operator-disabled vs CRD-unsupported scenarios - Simplify mnnvl-comprehensive-bare.yaml to 2 PCLQs (GPU + CPU) - Remove 4 redundant tests covered by testMNNVLEndToEnd: testMNNVLComputeDomainAndClaimInjection, testMultipleGroupsInOnePCS, testPCLQOptOutOverridesParent, testThreeLayerPCSPCSGPCLQAllDifferent - Delete 4 corresponding YAML fixtures - Move finalizer-blocks-deletion check into testMNNVLEndToEnd Co-authored-by: Cursor <cursoragent@cursor.com>
shayasoolin
approved these changes
May 7, 2026
danbar2
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind feature
Summary
grove.io/mnnvl-group) model introduced in refactor(mnnvl): replace two-annotation model with single mnnvl-group annotation #574operator/e2e/yaml/auto-mnnvl/, aligning with the repository's existing E2E patternsapplyMNNVLYAMLhelper to dynamically patch PCS resource names for test isolationtestMNNVLEndToEndcovering all annotation propagation layers (PCS → PCSG → PCLQ) with inherit/override/opt-out combinations, plus scale-out, scale-in, and deletionsupported_but_disabled_test.goandshared_cases.goto useAnnotationMNNVLGroupTest plan
make checkpasses (lint, format, codegen)go vet -tags=e2e ./e2e/tests/auto-mnnvl/...compiles cleanlyRef #417
Made with Cursor