Skip to content

Fix decode test error for operator config defaults#581

Merged
danbar2 merged 2 commits into
ai-dynamo:mainfrom
xianlubird:bug/decode-test
May 12, 2026
Merged

Fix decode test error for operator config defaults#581
danbar2 merged 2 commits into
ai-dynamo:mainfrom
xianlubird:bug/decode-test

Conversation

@xianlubird

@xianlubird xianlubird commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix #580

Issue #580

--- FAIL: TestDecodeOperatorConfig (0.00s)
    --- FAIL: TestDecodeOperatorConfig/defaults_applied_for_minimal_YAML (0.00s)
        decode_test.go:70: 
            	Error Trace:	/Users/admin/work/go/src/github.com/ai-dynamo/grove/operator/api/config/v1alpha1/decode_test.go:70
            	            				/Users/admin/work/go/src/github.com/ai-dynamo/grove/operator/api/config/v1alpha1/decode_test.go:117
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 10
            	Test:       	TestDecodeOperatorConfig/defaults_applied_for_minimal_YAML
        decode_test.go:72: 
            	Error Trace:	/Users/admin/work/go/src/github.com/ai-dynamo/grove/operator/api/config/v1alpha1/decode_test.go:72
            	            				/Users/admin/work/go/src/github.com/ai-dynamo/grove/operator/api/config/v1alpha1/decode_test.go:117
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 5
            	Test:       	TestDecodeOperatorConfig/defaults_applied_for_minimal_YAML
        decode_test.go:74: 
            	Error Trace:	/Users/admin/work/go/src/github.com/ai-dynamo/grove/operator/api/config/v1alpha1/decode_test.go:74
            	            				/Users/admin/work/go/src/github.com/ai-dynamo/grove/operator/api/config/v1alpha1/decode_test.go:117
            	Error:      	Not equal: 
            	            	expected: 1
            	            	actual  : 10
            	Test:       	TestDecodeOperatorConfig/defaults_applied_for_minimal_YAML
FAIL
FAIL	github.com/ai-dynamo/grove/operator/api/config/v1alpha1	0.472s
FAIL

@copy-pr-bot

copy-pr-bot Bot commented May 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@xianlubird xianlubird changed the title Fix operator config decode defaults Fix decode test error for operator config defaults May 6, 2026
@danbar2

danbar2 commented May 6, 2026

Copy link
Copy Markdown
Contributor

good catch ! please, add this test and all other module test to the CI test step - to avoid such cases in the future

shayasoolin
shayasoolin previously approved these changes May 6, 2026
View reviewed changes
@xianlubird

xianlubird commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

@danbar2 Pls help approve this

@danbar2

danbar2 commented May 10, 2026

Copy link
Copy Markdown
Contributor

@danbar2 Pls help approve this

Sure, please address my previous comment and I will approve

@xianlubird

xianlubird commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

@danbar2 @shayasoolin I have addressed the review comment by updating the CI unit test step to run tests across all Go modules. Could you please help review again? Thanks!

danbar2
danbar2 approved these changes May 11, 2026
View reviewed changes

@danbar2 danbar2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! approved

xianlubird added 2 commits May 12, 2026 13:52
@xianlubird @danbar2
test: fix operator config decode defaults
8355a67 
Signed-off-by: xianlubird <xianlubird@gmail.com>
@xianlubird @danbar2
ci: run unit tests for all Go modules
8f43ac4 
Signed-off-by: xianlubird <xianlubird@gmail.com>
@danbar2 danbar2 force-pushed the bug/decode-test branch from 5ce940e to 8f43ac4 Compare May 12, 2026 10:52
@danbar2 danbar2 merged commit dc7ff6a into ai-dynamo:main May 12, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbar2 danbar2 danbar2 approved these changes

@shayasoolin shayasoolin shayasoolin approved these changes

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

@sanjaychatterjee sanjaychatterjee Awaiting requested review from sanjaychatterjee sanjaychatterjee is a code owner

@gflarity gflarity Awaiting requested review from gflarity gflarity is a code owner

@Ronkahn21 Ronkahn21 Awaiting requested review from Ronkahn21 Ronkahn21 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Go Test Error -- decode_test error

3 participants

@xianlubird @danbar2 @shayasoolin