Skip to content

docs: add helm template / GitOps installation guidance#572

Merged
danbar2 merged 1 commit into
ai-dynamo:mainfrom
yankay:docs/536-helm-template-kustomize-guidance
May 3, 2026
Merged

docs: add helm template / GitOps installation guidance#572
danbar2 merged 1 commit into
ai-dynamo:mainfrom
yankay:docs/536-helm-template-kustomize-guidance

Conversation

@yankay

@yankay yankay commented May 1, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds a short "Advanced: helm template and GitOps" section to the installation guide, surfacing the recommended crdInstaller.enabled=true path from GREP-436 so users deploying via helm template, ArgoCD, Flux, or Kustomize don't hit a broken fresh install due to missing CRDs.

Which issue(s) this PR fixes:

Fixes #536

Special notes for your reviewer:

Kept the addition minimal and placed it after "Verify Installation" so it does not distract helm install users on the main path. Links to GREP-436 for the full design and the alternative --include-crds workflow.

Does this PR introduce a API change?

NONE

Additional documentation e.g., enhancement proposals, usage docs, etc.:


@copy-pr-bot

copy-pr-bot Bot commented May 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: adab52eab0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/installation.md Outdated
@yankay yankay force-pushed the docs/536-helm-template-kustomize-guidance branch from adab52e to e783499 Compare May 1, 2026 15:04
Surfaces the recommended GREP-436 path for users deploying Grove via
`helm template | kubectl apply`, ArgoCD, Flux, or Kustomize:

* Set `crdInstaller.enabled=true` so CRDs are installed/upgraded by the
  operator's init container, rather than relying on Helm rendering the
  chart's `crds/` directory (which `helm template` skips by default).
* Set `webhookServerSecret.enabled=false` so the chart does not keep
  rendering an empty TLS Secret that overwrites the operator's
  auto-generated cert on every re-apply or GitOps sync. This is already
  documented in `operator/charts/values.yaml` and the secret template;
  the new section just makes it discoverable from the install doc.

Placed after "Verify Installation" so it does not distract `helm install`
users on the main path. Links to GREP-436 for the full CRD design and the
alternative `--include-crds` workflow.

Signed-off-by: Kay Yan <kay.yan@daocloud.io>
@danbar2 danbar2 force-pushed the docs/536-helm-template-kustomize-guidance branch from e783499 to 2123301 Compare May 3, 2026 05:09
@danbar2 danbar2 merged commit 08ad3b3 into ai-dynamo:main May 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add helm template / kustomize CRD installation guidance

3 participants