refactor(mnnvl): remove auto-MNNVL mutating webhook, switch to opt-in#559
Merged
shmuel-runai merged 4 commits intoApr 30, 2026
Merged
Conversation
Remove the MutateAutoMNNVL defaulting webhook that automatically injected the grove.io/auto-mnnvl annotation onto GPU PodCliqueSets. MNNVL is now purely opt-in: users must explicitly set the annotation on their PCS. Add validation rejecting MNNVL annotations on non-GPU PodCliques. Update E2E tests to explicitly opt-in to MNNVL via annotations. Made-with: Cursor
gflarity
reviewed
Apr 28, 2026
shayasoolin
reviewed
Apr 29, 2026
Made-with: Cursor
shayasoolin
previously approved these changes
Apr 29, 2026
danbar2
reviewed
Apr 30, 2026
danbar2
reviewed
Apr 30, 2026
Made-with: Cursor
danbar2
approved these changes
Apr 30, 2026
shayasoolin
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind feature
Summary
MutateAutoMNNVLfrom the defaulting webhook — MNNVL is now purely opt-in via explicitgrove.io/auto-mnnvlannotationnetworkConfigfrom the defaulting handler since it's no longer neededKey changes
webhook.go: DeleteMutateAutoMNNVL, add non-GPU PCLQ validation invalidatePodCliqueTemplateSpecOnCreatedefaulting/handler.go: RemovenetworkConfigfield and MNNVL mutation fromDefault()register.go: SimplifyNewHandler(mgr)call (no longer needs network config)buildGPUPCSWithMNNVLhelper to explicitly set annotations; rewritetestPCSGetsAutoAnnotationto verify opt-in semanticsWhich issue(s) this PR fixes
Ref #417
Test plan
ResolveGroupNameinhelpers_test.goTestValidatePCSOnCreate_NonGPUCliqueWithMNNVL— validates rejection of MNNVL on non-GPU cliquesTestMNNVL_WebhookPipeline_LegacyPCSUpdate— simplified to single case (no mutation on update)go build ./...andgo testpassMade with Cursor
Made with Cursor