feat(mnnvl): add group-aware MNNVL injection into PodSpec#557
Merged
shmuel-runai merged 3 commits intoApr 28, 2026
Merged
Conversation
When injecting MNNVL into a PodSpec, the controller now uses the correct RCT name for the target MNNVL group. Controllers resolve the MNNVL group from annotations hierarchically — clique annotations take priority over PCS/PCSG annotations. Key changes: - Move resolveGroupName to mnnvl.ResolveGroupName (exported) - Add groupName parameter to InjectMNNVLIntoPodSpec - Update PCS and PCSG controllers with hierarchical group resolution - Add group-aware test cases for both PCS and PCSG injection Made-with: Cursor
danbar2
reviewed
Apr 28, 2026
danbar2
previously approved these changes
Apr 28, 2026
shayasoolin
reviewed
Apr 28, 2026
danbar2
previously approved these changes
Apr 28, 2026
…ution Replace the manual two-step ResolveGroupName fallback in both PCS and PCSG controllers with a variadic ResolveGroupNameHierarchically helper. The first annotation layer that requests MNNVL wins, letting a child layer intentionally override its parent's group (including escaping a named group back to the default). Add code comments clarifying that PCS-level annotations are already propagated onto the PCSG via propagateMNNVLAnnotations, so the two-layer check (PCLQ → PCSG) is sufficient. Made-with: Cursor
495f173 to
97d16ca
Compare
danbar2
approved these changes
Apr 28, 2026
shayasoolin
reviewed
Apr 28, 2026
shayasoolin
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResolveGroupNamefrom themnnvlpackage and addgroupNameparameter toInjectMNNVLIntoPodSpecKey changes
resolveGroupNametomnnvl.ResolveGroupName(exported)groupNameparameter toInjectMNNVLIntoPodSpecWhich issue(s) this PR fixes
Ref #417
Test plan
ResolveGroupNameinhelpers_test.goInjectMNNVLIntoPodSpecwith named groups ininjection_test.goTestBuildResource_MNNVLInjection— group on PCS, clique override, clique-onlyTestBuildResource_MNNVLInjection— group on PCSG, clique override, clique-onlymake checkpasses (no dirty tree)Made with Cursor